fix e2ee defaults masked in release builds#126
Merged
stephen-derosa merged 2 commits intoMay 12, 2026
Conversation
stephen-derosa
requested review from
alan-george-lk and
xianshijing-lk
as code owners
alan-george-lk
approved these changes
May 12, 2026
float up missing e2ee fields e2ee: toProto
stephen-derosa
force-pushed
the
sderosa/bugfix/e2ee-defaults
branch
from
0c8d9f1 to
438394c
Compare
alan-george-lk
approved these changes
May 12, 2026
xianshijing-lk
approved these changes
May 12, 2026
Collaborator
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
one nit and one question.
lgtm
stephen-derosa
force-pushed
the
sderosa/bugfix/e2ee-defaults
branch
from
8f11eb6 to
add61d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
correctly populate defaults for e2ee proto
Testing
debug integration tests running locally
Linear Ticket
https://linear.app/livekit/issue/BOT-357/e2ee-missing-proto-fields